zfs_vnops_os.c: fallocate is valid but not supported on FreeBSD #16918
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works around /usr/lib/go-1.18/pkg/tool/linux_amd64/link: mapping output file failed: invalid argument It's happened to me under a Linux jail, but it's also happened to other people, see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270247#c4 Signed-off-by: pstef <[email protected]>
amotin
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
From one side POSIX does not define this error code for posix_fallocate(), probably expecting emulation via writing, which could be implemented by vop_stdallocate() here. But writing makes no sense for ZFS. From another side Linux posix_fallocate() man page documents EOPNOTSUPP as possible error for libc implementation not providing emulation.
So I lean to agree that VOP_EOPNOTSUPP is indeed better than VOP_EINVAL, but open to other thoughts in general in case I miss something.
behlendorf
approved these changes
Jan 2, 2025
behlendorf
added
Status: Accepted
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
Jan 3, 2025
This works around /usr/lib/go-1.18/pkg/tool/linux_amd64/link: mapping output file failed: invalid argument It's happened to me under a Linux jail, but it's also happened to other people, see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270247#c4 Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Alexander Motin <[email protected]> Signed-off-by: pstef <[email protected]> Closes openzfs#16918
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around
/usr/lib/go-1.18/pkg/tool/linux_amd64/link: mapping output file failed: invalid argumentIt happened to me under a Linux jail, but it also happened to other people, see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270247#c4
I've been running this on my laptop for months with success and no new errors.
Types of changes
Checklist:
Signed-off-by.